Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add additional input parameters and child module for App Insights AVM module #896

Merged
merged 6 commits into from
Feb 5, 2024
Merged

feat: add additional input parameters and child module for App Insights AVM module #896

merged 6 commits into from
Feb 5, 2024

Conversation

tyconsulting
Copy link
Contributor

Description

closes #895

Pipeline

avm.res.insights.component

Adding a new module

  • A proposal has been submitted and approved.
  • I have included "Closes #{module_proposal_issue_number}" in the PR description.
  • I have run brm validate locally to verify the module files.
  • I have run deployment tests locally to ensure the module is deployable.

Updating an existing module

  • This is a bug fix:
    • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
    • The bug was found by the module author, and no one has opened an issue to report it yet.
  • I have run brm validate locally to verify the module files.
  • I have run deployment tests locally to ensure the module is deployable.
  • I have read the Updating an existing module section in the contributing guide and updated the version.json file properly:
    • The PR contains backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json.
    • The PR contains backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • The PR contains breaking changes, and I have bumped the MAJOR version in version.json.
  • I have updated the examples in README with the latest module version number.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Jan 31, 2024
@tyconsulting tyconsulting marked this pull request as ready for review January 31, 2024 12:17
@tyconsulting tyconsulting requested review from a team as code owners January 31, 2024 12:17
@AlexanderSehr AlexanderSehr added Class: Resource Module 📦 This is a resource module and removed Needs: Triage 🔍 Maintainers need to triage still labels Jan 31, 2024
@AlexanderSehr
Copy link
Contributor

Hey @tyconsulting, thanks for your contribution. @krbar will review it once he's back in the office :)
We're on it.

krbar
krbar reviewed Feb 2, 2024
View reviewed changes
Copy link
Contributor

@krbar krbar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @tyconsulting, nice contribution, thank you! Looks good to me, I just added a small suggestion to align the deployment name of the child module to the other. A re-generation of the ARM file will be needed. Please also re-run the workflow after the change.

avm/res/insights/component/main.bicep Outdated Show resolved Hide resolved
@tyconsulting
Copy link
Contributor Author

Hello @tyconsulting, nice contribution, thank you! Looks good to me, I just added a small suggestion to align the deployment name of the child module to the other. A re-generation of the ARM file will be needed. Please also re-run the workflow after the change.

hi @krbar thanks for reviewing this PR. I have updated it as per your suggestion. Please take another look. here's the result of the latest pipeline run:

avm.res.insights.component

@krbar
Copy link
Contributor

krbar commented Feb 5, 2024

@Azure/avm-core-team-technical-bicep PR is fine from my point of view and can be merged, please approve.

jtracey93
jtracey93 approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving as advised by @krbar

@jtracey93 jtracey93 merged commit 2194eb1 into Azure:main Feb 5, 2024
9 checks passed
@tyconsulting tyconsulting deleted the users/tao/895_appInsights branch February 5, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krbar krbar krbar left review comments

@jtracey93 jtracey93 jtracey93 approved these changes

Assignees

@tyconsulting tyconsulting

Labels
Class: Resource Module 📦 This is a resource module Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[AVM Module Issue]: App Insights Resource module missing parameters
4 participants
@tyconsulting @AlexanderSehr @krbar @jtracey93